Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add part name #63

Merged
merged 8 commits into from
Jan 30, 2024

Conversation

Bouni
Copy link
Contributor

@Bouni Bouni commented Jan 19, 2024

This PR is meant to work together with PR ModischFabrications/CutSolver#60 and allows to enter a part name per item which is then displayed on the cut list.

Screenshot 2024-01-19 142800

@Bouni Bouni mentioned this pull request Jan 24, 2024
@ModischFabrications
Copy link
Owner

Test seem to fail because of invalid test setup, do they work locally for you? Build error points to outdated axios import style, but I've become a bit rusty.

@Bouni
Copy link
Contributor Author

Bouni commented Jan 28, 2024

Have to check tomorrow

@Bouni
Copy link
Contributor Author

Bouni commented Jan 29, 2024

With npm run test:unit all tests succeed for me locally:

Test Suites: 1 passed, 1 total
Tests:       6 passed, 6 total
Snapshots:   0 total
Time:        17.65 s
Ran all test suites.

But I see a ton of warnings and deprecation warnings

@Bouni
Copy link
Contributor Author

Bouni commented Jan 29, 2024

Ok, I can reproduce the error. If I run npm ci it installes packages I guess (not sure) and afterwards npm run test:unit I get the same error as the GH action shows.

After some seraching I fount this jest issue: axios/axios#5101 (comment)

When I add the suggested solution to the jest.config.js it works as before.

I've no idea why it worked in the first place for me 😅

Anyway, I just pushed that change and it should run in the CI as well now

@Bouni
Copy link
Contributor Author

Bouni commented Jan 30, 2024

@ModischFabrications Anything I missed? Would you mind approve a CI run to see if things are right now?

@ModischFabrications
Copy link
Owner

CI seems to work now, good work 👍🏻
Not sure why I need to approve all runs, might look into it later

@Bouni
Copy link
Contributor Author

Bouni commented Jan 30, 2024

So do you plan to merge this one as well as ModischFabrications/CutSolver#60 soon?

@ModischFabrications
Copy link
Owner

Yes, the next few evenings.

@Bouni
Copy link
Contributor Author

Bouni commented Jan 30, 2024

Nice 😎

@ModischFabrications ModischFabrications merged commit 5239661 into ModischFabrications:master Jan 30, 2024
2 checks passed
@ModischFabrications
Copy link
Owner

Also promoted with updated CI here, but the multiarch build seems to take forever. Let's hope it goes through, I would need to exclude non-x64 platforms otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants