-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add part name #63
Feature: Add part name #63
Conversation
Test seem to fail because of invalid test setup, do they work locally for you? Build error points to outdated axios import style, but I've become a bit rusty. |
Have to check tomorrow |
With
But I see a ton of warnings and deprecation warnings |
Ok, I can reproduce the error. If I run After some seraching I fount this jest issue: axios/axios#5101 (comment) When I add the suggested solution to the I've no idea why it worked in the first place for me 😅 Anyway, I just pushed that change and it should run in the CI as well now |
@ModischFabrications Anything I missed? Would you mind approve a CI run to see if things are right now? |
CI seems to work now, good work 👍🏻 |
So do you plan to merge this one as well as ModischFabrications/CutSolver#60 soon? |
Yes, the next few evenings. |
Nice 😎 |
5239661
into
ModischFabrications:master
Also promoted with updated CI here, but the multiarch build seems to take forever. Let's hope it goes through, I would need to exclude non-x64 platforms otherwise. |
This PR is meant to work together with PR ModischFabrications/CutSolver#60 and allows to enter a part name per item which is then displayed on the cut list.